[vlc-devel] [PATCH] Fixed #19993: Made toolTips on Full Screen consistent

Thomas Guillem thomas at gllm.fr
Mon Mar 19 13:20:35 CET 2018


Just one comment about your commit title/message:
- You should mention that it's a macos patch by prefixing your title
  with "macos: "- You should use the imperative form: Made => Make
- Mention the track ticket in the commit message (and not the title)
  like "Fixes #19993"
On Mon, Mar 19, 2018, at 12:02, Daksh Shah wrote:
> Now the tooltips which are shown in the Normal View are same as the
> ones which are shown in Full-Screen View. Adapted the shorter version.> And also, changed the Normal View toolTip of "Fullscreen" to "Enter
> fullscreen"> 
> _________________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel
> Email had 1 attachment:

>  * 0001-Fixed-19993-Made-toolTips-on-Full-Screen-consistent.patch 5k
>    (text/plain)
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20180319/159a78c2/attachment.html>

More information about the vlc-devel mailing list