[vlc-devel] [PATCH 0/1] Improve SFTP network performance with buffer

Martin Disch martindisch at gmail.com
Mon Mar 19 21:48:52 CET 2018


On Mon, Mar 19, 2018 at 8:07 PM, RĂ©mi Denis-Courmont <remi at remlab.net> wrote:
> Eh? SFTP is one of those plug-ins that can fail miserably with large read size
> (if bandwidth is low), as well as small read size (if bandwidth and/or latency
> are high).
>
> The whole point is that increasing the read size is breaking it as much as it
> is fixing it.

Yes. I was referring to the fact that while I can solve my problem by
changing the read size to a "better" value for my setup, this is not a
generally applicable solution.

>> And reverting to using a separate read size setting for the SFTP
>> module as it was before 3.0 is not great either, because that would
>> defeat the purpose of the prefetch module.
>
> There never was a separate read size for SFTP.

There was a setting in the SFTP module called "Read size". See
screenshot at (1), taken from VLC 2.2.8. And if I remember correctly,
that was the exact value that was used as the read size in
libssh2_sftp_read() calls. I remember because back then that was part
of the solution that helped me improve streaming playback.

(1) https://imgur.com/a/yHl8h

--
Martin Disch
martindisch at gmail.com


More information about the vlc-devel mailing list