[vlc-devel] [PATCH 0/1] Improve SFTP network performance with buffer

[Rémi Denis-Courmont]

Le lundi 19 mars 2018, 22:48:52 EET Martin Disch a écrit :
> On Mon, Mar 19, 2018 at 8:07 PM, Rémi Denis-Courmont <remi at remlab.net> 
wrote:
> > Eh? SFTP is one of those plug-ins that can fail miserably with large read
> > size (if bandwidth is low), as well as small read size (if bandwidth
> > and/or latency are high).
> > 
> > The whole point is that increasing the read size is breaking it as much as
> > it is fixing it.
> 
> Yes. I was referring to the fact that while I can solve my problem by
> changing the read size to a "better" value for my setup, this is not a
> generally applicable solution.
> 
> >> And reverting to using a separate read size setting for the SFTP
> >> module as it was before 3.0 is not great either, because that would
> >> defeat the purpose of the prefetch module.
> > 
> > There never was a separate read size for SFTP.
> 
> There was a setting in the SFTP module called "Read size".

Fair enough, I was wrongly assuming SFTP was like NFS and CIFS in this 
respect. Still, the default read size was even smaller than that of the 
prefetch plug-in is now.

CIFS, NFS and SFTP should probably be marked fast-seekable. The upside of not 
pipelining is that seeking is actually as fast or almost as fast as not 
seeking.

The proper "fix" is to implement pipelining, but that basically means 
implementing the protocols inside VLC directly - which seems overkill and too 
much work.

-- 
Rémi Denis-Courmont