[vlc-devel] [patch] vobsub: fix rgb2yuv

jnqnfe at gmail.com jnqnfe at gmail.com
Mon May 7 04:56:35 CEST 2018

vobsub: fix rgb2yuv

gave yvu instead of yuv

I am only guessing that this is wrong (not in a position to research
the vobsub format at the moment). It is clear that it is outputting YVU
order not YUV in the 32-bit int it constructs, which contradicts the
very name of the function. It's called from vobsub_palette_parse(),
which is processing a string of comma separated RGB channel values
(specifically four sets of them representing a pallette).

The current code comes from a1fbc87008cf08d90c6afe1ef24c2c814b180ff1
which replaces some older code with the same logic. The original bug,
if indeed a bug, comes from f22c47d8dd7821fb1bd1be41319104101fbd1780

In the original code it looks more deliberate.

If the existing code is correct, then alternately some comments need
adding, and possibly a renaming of the misleading function name.

cc'd to original author.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: vobsub_fix_rgb2yuv.patch
Type: text/x-patch
Size: 866 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20180507/006b373f/attachment.bin>

More information about the vlc-devel mailing list