[vlc-devel] [PATCH] configure: fix using protoc from the built tools

[Steve Lhomme]

On Thu, May 17, 2018, at 16:14, Rémi Denis-Courmont wrote:
> And? Make and configure are supposed to run in the same
> environment, precisely because the results of configure are meant
> to be used by make.> 
>  There are no reasons why the protobuf compiler would use full path
>  and other compilers would not.
LUAC='/c/Users/robux/Documents/Programs/Videolabs/work/contrib/x86_64-
w64-mingw32/../bin/x86_64-w64-mingw32-luac.exe'
Basically the C/C++ are exceptions rather than the norm. Everything else
in the environment when you run configure is saved in variables reused
when you call make. Changing the environment when you call make has
little to no effect at all. I don't see why the PATH should be any
different.
it's very inconvenient to have to remember to reset your PATH whenever
you switch to another build directory and prone to a lot of time wasting
errors. When we have all the tools to avoid that.

> 
>  Full path is useful if you need to access the file, or if you need to
>  use the path after/outside the build process.> 
> Le 17 mai 2018 16:48:14 GMT+03:00, Steve Lhomme  <robux4 at ycbcr.xyz>
> a écrit :>> I do. I have one in extra/tools (3.1) and one on my system (3.5) and
>> without this it uses the wrong one.>> 
>> 
>> On Wed, May 16, 2018, at 18:43, Rémi Denis-Courmont wrote:
>>> Le keskiviikkona 16. toukokuuta 2018, 17.01.55 EEST Steve Lhomme a
>>> écrit :>>>> Otherwise we don't have the proper path.
>>> 
>>> You obviously don't need the full path here.
>>> 
>>> Nack.
>>> 
>>> --
>>> Реми Дёни-Курмон
>>> http://www.remlab.net/
>>> _________________________________________________
>>> vlc-devel mailing list
>>> To unsubscribe or modify your subscription options:
>>> https://mailman.videolan.org/listinfo/vlc-devel
>> 
> 
> --
>  Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez
>  excuser ma brièveté.> _________________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20180518/2c4f6127/attachment.html>