[vlc-devel] [PATCH] configure: fix using protoc from the built tools

[Rémi Denis-Courmont]

Le perjantaina 18. toukokuuta 2018, 9.57.54 EEST Steve Lhomme  a écrit :
> LUAC='/c/Users/robux/Documents/Programs/Videolabs/work/contrib/x86_64-
> w64-mingw32/../bin/x86_64-w64-mingw32-luac.exe'

Actually LUAC is probed using CHECK_TOOL, not PATH_TOOL.

> Basically the C/C++ are exceptions rather than the norm.

No, that is the norm, not the exception: CC, CXX, OBJC, BUILDCC, OBJDUMP, 
OBJCOPY, RANLIB, STRIP,  NM, WINDRES, unix2dos, PROTOC, DESKTOP_FILE_VALIDATE, 
LUAC, LEX, BISON, KDE4_CONFIG are all using the simple form.

And most AC_PATH_PROG calls are cargo-culted/copy-pasted without consideration 
whether it was actually needed.

> Everything else
> in the environment when you run configure is saved in variables reused
> when you call make. Changing the environment when you call make has
> little to no effect at all. I don't see why the PATH should be any
> different.
> it's very inconvenient to have to remember to reset your PATH whenever
> you switch to another build directory and prone to a lot of time wasting
> errors.

No. It is not using the same environment that is prone to errors.

configure even checks to prevent the most obvious errors.

-- 
Реми Дёни-Курмон
http://www.remlab.net/