[vlc-devel] [PATCH] configure: fix using protoc from the built tools

[Steve Lhomme]

On Fri, May 18, 2018, at 11:33, Rémi Denis-Courmont wrote:
> Le perjantaina 18. toukokuuta 2018, 10.36.29 EEST Steve Lhomme
> a écrit :>>> No. It is not using the same environment that is prone to errors.
>> 
>> Exactly, so forcing the user to change the environment for
>> each folder>> one compiles in is prone to errors.
> 
> We actively support prefixed cross-"tools" and subdir builds, so one
> can have> as many targets as one wants in a single shell/environment. You can
> also force> any variable you want to point to anything suitable for any target.

That's one way of doing things. That is extremly incovenient when you
deal with many branches that have different configure.ac/contribs.
> 
> But if the user proactively changes the environment before
> configure, then> that must be reproduced for make and any cached rerun of configure.
> Likewise,> any environment change within configure itself must be reflected in
> make. So> patching CC or CFLAGS in configure is fine. But patching PATH or
> LD_LIBRARY_PATH is wrong.
> 
> Now assuming that you neither patch PATH before running configure, and> configure does not patch PATH either, I don't see the point of your
> patch...
You don't see how running /usr/bin/protoc (in the PATH) instead of
/path/to/vlc/extra/tools/bin/protoc can be a problem ?
> 
> --
> レミ・デニ-クールモン
> http://www.remlab.net/
> 
> 
> 
> _________________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20180518/b48262d7/attachment.html>