[vlc-devel] [PATCH] NSIS: Quote UninstallString path

Marvin Scholz epirat07 at gmail.com
Thu May 24 20:39:49 CEST 2018


Thanks to John Moser for pointing this out.
---
 extras/package/win32/NSIS/vlc.win32.nsi.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/extras/package/win32/NSIS/vlc.win32.nsi.in b/extras/package/win32/NSIS/vlc.win32.nsi.in
index 1169c1eecd..b5e0e1af01 100644
--- a/extras/package/win32/NSIS/vlc.win32.nsi.in
+++ b/extras/package/win32/NSIS/vlc.win32.nsi.in
@@ -803,7 +803,7 @@ Section -Post
   WriteRegStr ${PRODUCT_UNINST_ROOT_KEY} "${PRODUCT_UNINST_KEY}" \
     "DisplayName" "$(^Name)"
   WriteRegStr ${PRODUCT_UNINST_ROOT_KEY} "${PRODUCT_UNINST_KEY}" \
-    "UninstallString" "$INSTDIR\uninstall.exe"
+    "UninstallString" "$\"$INSTDIR\uninstall.exe$\""
   WriteRegStr ${PRODUCT_UNINST_ROOT_KEY} "${PRODUCT_UNINST_KEY}" \
     "InstallLocation" "$INSTDIR"
   WriteRegStr ${PRODUCT_UNINST_ROOT_KEY} "${PRODUCT_UNINST_KEY}" \
-- 
2.15.1 (Apple Git-101)



More information about the vlc-devel mailing list