[vlc-devel] [PATCH] NSIS: Quote UninstallString path

[Jean-Baptiste Kempf]

LGTM, ofc.

On Thu, 24 May 2018, at 20:39, Marvin Scholz wrote:
> Thanks to John Moser for pointing this out.
> ---
>  extras/package/win32/NSIS/vlc.win32.nsi.in | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/extras/package/win32/NSIS/vlc.win32.nsi.in b/extras/
> package/win32/NSIS/vlc.win32.nsi.in
> index 1169c1eecd..b5e0e1af01 100644
> --- a/extras/package/win32/NSIS/vlc.win32.nsi.in
> +++ b/extras/package/win32/NSIS/vlc.win32.nsi.in
> @@ -803,7 +803,7 @@ Section -Post
>    WriteRegStr ${PRODUCT_UNINST_ROOT_KEY} "${PRODUCT_UNINST_KEY}" \
>      "DisplayName" "$(^Name)"
>    WriteRegStr ${PRODUCT_UNINST_ROOT_KEY} "${PRODUCT_UNINST_KEY}" \
> -    "UninstallString" "$INSTDIR\uninstall.exe"
> +    "UninstallString" "$\"$INSTDIR\uninstall.exe$\""
>    WriteRegStr ${PRODUCT_UNINST_ROOT_KEY} "${PRODUCT_UNINST_KEY}" \
>      "InstallLocation" "$INSTDIR"
>    WriteRegStr ${PRODUCT_UNINST_ROOT_KEY} "${PRODUCT_UNINST_KEY}" \
> -- 
> 2.15.1 (Apple Git-101)
> 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel


-- 
Jean-Baptiste Kempf -  President
+33 672 704 734