[vlc-devel] [PATCH] Input and Output modules for the Reliable Internet Stream Transport (RIST) Protocol.

[Sergio M. Ammirata]

J-B,

Parameters: latency, retry-interval, reorder-buffer, max-retries
These parameters are needed to properly fine tune the algorithm. I have added sensible defaults that should cover your typical connections but they need to be adjusted for unusually high (or low) round trip times.
 
nack-type is needed for when the sender only supports one of the two types.

packet-size allows you to adjust to the MTU of the network.

poll-timeout could be lowered from the default of 5ms when the demux/decoding chain cannot tolerate that much jitter. A lower value comes at the expense of a tighter loop and more CPU usage.

Lastly, eof-on-reset allows you to control the behavior of the buffer reset event. Depending on the type of output, eof is more adequate than sending a timestamp discontinuity down the chain.

Regards,

Sergio Ammirata

-----Original Message-----
From: Jean-Baptiste Kempf [mailto:jb at videolan.org] 
Sent: Sunday, October 21, 2018 8:43 PM
To: Sergio M. Ammirata; vlc-devel at videolan.org
Subject: Re: [vlc-devel] [PATCH] Input and Output modules for the Reliable Internet Stream Transport (RIST) Protocol.


On Sun, 21 Oct 2018, at 16:57, Sergio M. Ammirata wrote:
> All issues are fixed, here is in the revised input module patch.

So:
- missing NEWS, po/POTFILES.in, modules/MODULE_LIST entries
- you must surround the poll.h include with HAVE_POLL
- use str*cpy instead of strcpy

Also, you have many options in this module. Are they all necessary?

best,


-- 
Jean-Baptiste Kempf -  President
+33 672 704 734