[vlc-devel] [PATCH] Input and Output modules for the Reliable Internet Stream Transport (RIST) Protocol.

[Sergio M. Ammirata]

No problem, I will  change the strcpy for strncpy since I have the exact length anyway.

-----Original Message-----
From: vlc-devel [mailto:vlc-devel-bounces at videolan.org] On Behalf Of Thomas Guillem
Sent: Monday, October 22, 2018 3:39 AM
To: vlc-devel at videolan.org
Subject: Re: [vlc-devel] [PATCH] Input and Output modules for the Reliable Internet Stream Transport (RIST) Protocol.



On Mon, Oct 22, 2018, at 09:23, Thomas Guillem wrote:
> 
> On Mon, Oct 22, 2018, at 02:42, Jean-Baptiste Kempf wrote:
> > 
> > On Sun, 21 Oct 2018, at 16:57, Sergio M. Ammirata wrote:
> > > All issues are fixed, here is in the revised input module patch.
> > 
> > So:
> > - missing NEWS, po/POTFILES.in, modules/MODULE_LIST entries
> > - you must surround the poll.h include with HAVE_POLL
> 
> > - use str*cpy instead of strcpy
> 
> Where strcpy is used, dst and src have the same length. I don't know 
> the convention, but for me, strcpy is good in that case.

Forget it, I though the src param was static const, but it's not. So yes, strcpy is bad here.

> 
> > 
> > Also, you have many options in this module. Are they all necessary?
> > 
> > best,
> > 
> > 
> > --
> > Jean-Baptiste Kempf -  President
> > +33 672 704 734
> > _______________________________________________
> > vlc-devel mailing list
> > To unsubscribe or modify your subscription options:
> > https://mailman.videolan.org/listinfo/vlc-devel
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel
_______________________________________________
vlc-devel mailing list
To unsubscribe or modify your subscription options:
https://mailman.videolan.org/listinfo/vlc-devel