[vlc-devel] [vlc-commits] modules: common: use full name as MODULE_NAME

[Rémi Denis-Courmont]

Le vendredi 26 octobre 2018, 17:20:52 EEST Thomas Guillem a écrit :
> vlc | branch: master | Thomas Guillem <thomas at gllm.fr> | Fri Oct 26 16:09:29
> 2018 +0200| [ea3d85bee860f741e96fa1ea6eb23d16c3ab5f3d] | committer: Thomas
> Guillem
> 
> modules: common: use full name as MODULE_NAME
> 
> MODULE_NAME is only used for static builds:
> 
> Here is an example:
> 
> for codec/liba52_plugin_la-a52.lo
>  MODULE_STRING=a52
>  MODULE_NAME=codec_a52
> 
> for packetizer/a52.lo
>  MODULE_STRING=a52
>  MODULE_NAME=packetizer_a52
> 
> This patch will fix conflicts with the 2 vlc_entry__a52 symbols (that will
> now be vlc_entry__codec_a52 and vlc_entry__packetize_a52).

You cannot be serious. This obviously breaks configuration items (audio 
output) and logs backward compatibility.

Please revert and fix your toolchain instead of wrecking the build system 
without even review.

-- 
Rémi Denis-Courmont