[vlc-devel] [vlc-commits] modules: common: use full name as MODULE_NAME

[Thomas Guillem]

On Fri, Oct 26, 2018, at 17:00, Rémi Denis-Courmont wrote:
> Le vendredi 26 octobre 2018, 17:20:52 EEST Thomas Guillem a écrit :
> > vlc | branch: master | Thomas Guillem <thomas at gllm.fr> | Fri Oct 26 16:09:29
> > 2018 +0200| [ea3d85bee860f741e96fa1ea6eb23d16c3ab5f3d] | committer: Thomas
> > Guillem
> > 
> > modules: common: use full name as MODULE_NAME
> > 
> > MODULE_NAME is only used for static builds:
> > 
> > Here is an example:
> > 
> > for codec/liba52_plugin_la-a52.lo
> >  MODULE_STRING=a52
> >  MODULE_NAME=codec_a52
> > 
> > for packetizer/a52.lo
> >  MODULE_STRING=a52
> >  MODULE_NAME=packetizer_a52
> > 
> > This patch will fix conflicts with the 2 vlc_entry__a52 symbols (that will
> > now be vlc_entry__codec_a52 and vlc_entry__packetize_a52).
> 

I reverted with a push --force. I should have asked for a review, right.

> You cannot be serious. This obviously breaks configuration items (audio 
> output) and logs backward compatibility.


How ? I did a make check, and compared the log before/after: the same. I can configure audio output and my vlc rc stay the same.

> 
> Please revert and fix your toolchain instead of wrecking the build system 
> without even review.

By the way, I can *not* fix Apple toolchain, and it is very hackish to rely on objcopy for every static builds.

For me, this patch still apply, but I'll wait for reviews.

> 
> -- 
> Rémi Denis-Courmont
> 
> 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel