[vlc-devel] [PATCH] modules: common: use full name as MODULE_NAME

Rémi Denis-Courmont remi at remlab.net
Fri Oct 26 17:14:18 CEST 2018

Le vendredi 26 octobre 2018, 18:07:10 EEST Thomas Guillem a écrit :
> MODULE_NAME is only used for static builds:

This looks like it will fail miserably when the build system is no longer 
recursive, whether that is with Meson or an update to the existing system.

And while we are not married to OBJCOPY, there are zero excuses for not having 
_a_ tool to edit relocatable objects in the SDK. Besides, static linking is 
not supported in the VLC build system anyway, so this does not belong here.

But worst of all, it actually changes the name of some existing plugins, those 
containing an underscore. Totally not OK.

Rémi Denis-Courmont

More information about the vlc-devel mailing list