[vlc-devel] [PATCH] modules: common: use full name as MODULE_NAME

[Thomas Guillem]

On Fri, Oct 26, 2018, at 17:14, Rémi Denis-Courmont wrote:
> Le vendredi 26 octobre 2018, 18:07:10 EEST Thomas Guillem a écrit :
> > MODULE_NAME is only used for static builds:
> 
> This looks like it will fail miserably when the build system is no longer 
> recursive, whether that is with Meson or an update to the existing system.

I don't really get this point.

> 
> And while we are not married to OBJCOPY, there are zero excuses for not having 
> _a_ tool to edit relocatable objects in the SDK.

Doing this patch seems a lot simpler.

>Besides, static linking is not supported in the VLC build system anyway, so this does not belong here.

I thought, from a previous discussion, that we decided to support it. That is why I decided to rename all function names that were identical.

> 
> But worst of all, it actually changes the name of some existing plugins, those 
> containing an underscore. Totally not OK.

Ah yes, good point. The STRING will be different in that case.

> 
> -- 
> Rémi Denis-Courmont
> 
> 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel