[vlc-commits] goom: remove useless filter_sys_t

[Hannes Domani]

Am Sonntag, 28. Oktober 2018, 15:35:31 MEZ hat Rémi Denis-Courmont <git at videolan.org> Folgendes geschrieben:

> vlc | branch: master | Rémi Denis-Courmont <remi at remlab.net> | Sun Oct 28 16:31:45 2018 +0200| [707c2f42bdc92567a3baa1ca1df3090bcc4ae218] | committer: Rémi Denis-Courmont
> 
> goom: remove useless filter_sys_t
> 
> > http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=707c2f42bdc92567a3baa1ca1df3090bcc4ae218
> ---
> 
> modules/visualization/goom.c | 54 ++++++++++++++++----------------------------
> 1 file changed, 20 insertions(+), 34 deletions(-)
> 
> diff --git a/modules/visualization/goom.c b/modules/visualization/goom.c
> index 039971be08..07191760bd 100644
> --- a/modules/visualization/goom.c
> +++ b/modules/visualization/goom.c
> @@ -116,15 +110,11 @@ static void *Thread( void * );
> static int Open( vlc_object_t *p_this )
> {
>     filter_t      *p_filter = (filter_t *)p_this;
> -    filter_sys_t  *p_sys;
>     goom_thread_t  *p_thread;
>     video_format_t fmt;
> 
> -    /* Allocate structure */
> -    p_sys = p_filter->p_sys = malloc( sizeof( filter_sys_t ) );
> -
>     /* Create goom thread */
> -    p_sys->p_thread = p_thread = calloc( 1, sizeof(*p_thread) );
> +    p_thread = calloc( 1, sizeof(*p_thread) );
> 
>     const int width  = p_thread->i_width  = var_InheritInteger( p_filter, "goom-width" );
>     const int height = p_thread->i_height = var_InheritInteger( p_filter, "goom-height" );

Shouldn't this be:
+    p_filter->p_sys = p_thread = calloc( 1, sizeof(*p_thread) );


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20181028/aa8b7b49/attachment.html>