[vlc-devel] [PATCH 2/2] decoder: remove vout polling from SPU decoders

Thomas Guillem thomas at gllm.fr
Wed Apr 3 10:01:48 CEST 2019


On Tue, Apr 2, 2019, at 18:26, Rémi Denis-Courmont wrote:
> Le tiistaina 2. huhtikuuta 2019, 19.19.26 EEST Thomas Guillem a écrit :
> > The cancel dance is still needed since it's not acceptable to block for
> > 6seconds.
> 
> In which scenario? AFAICT, this only addresses one corner case (user stop) 
> within another corner case (SPU w/o video). It does not look like it really 
> fixes the problem in any case other than stop (e.g. seeking or changing SPU 
> track).

I see 2 scenarios:
 - Open a video with subtitles using a defective vout: Ctrl-C, wait 6 seconds. It doesn't happen with --no-video.
 - Place a .stl with a music file: you can't stop playback for 6 seconds. It doesn't happen with .srt, I guess .stl subtitles are enabled by default. Why ?

> 
> -- 
> Rémi Denis-Courmont
> http://www.remlab.net/
> 
> 
> 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel


More information about the vlc-devel mailing list