[vlc-devel] [PATCH 2/2] decoder: remove vout polling from SPU decoders

[Rémi Denis-Courmont]

On further considerations, I think this (current code and patch) miss the point anyway. Using a video output that's not active is not currently supported. It's not enough to wait for the video output to exists.

AFAICT, it's unavoidable to either change the ES output or the video output or both to handle this.

Le 3 avril 2019 11:01:48 GMT+03:00, Thomas Guillem <thomas at gllm.fr> a écrit :
>
>On Tue, Apr 2, 2019, at 18:26, Rémi Denis-Courmont wrote:
>> Le tiistaina 2. huhtikuuta 2019, 19.19.26 EEST Thomas Guillem a écrit
>:
>> > The cancel dance is still needed since it's not acceptable to block
>for
>> > 6seconds.
>> 
>> In which scenario? AFAICT, this only addresses one corner case (user
>stop) 
>> within another corner case (SPU w/o video). It does not look like it
>really 
>> fixes the problem in any case other than stop (e.g. seeking or
>changing SPU 
>> track).
>
>I see 2 scenarios:
>- Open a video with subtitles using a defective vout: Ctrl-C, wait 6
>seconds. It doesn't happen with --no-video.
>- Place a .stl with a music file: you can't stop playback for 6
>seconds. It doesn't happen with .srt, I guess .stl subtitles are
>enabled by default. Why ?
>
>> 
>> -- 
>> Rémi Denis-Courmont
>> http://www.remlab.net/
>> 
>> 
>> 
>> _______________________________________________
>> vlc-devel mailing list
>> To unsubscribe or modify your subscription options:
>> https://mailman.videolan.org/listinfo/vlc-devel
>_______________________________________________
>vlc-devel mailing list
>To unsubscribe or modify your subscription options:
>https://mailman.videolan.org/listinfo/vlc-devel

-- 
Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20190403/1b0291f2/attachment.html>