[vlc-devel] [PATCH 1/2] compat: Workaround sendmsg bug on some ArmV8 Android devices

[Rémi Denis-Courmont]

Le maanantaina 1. huhtikuuta 2019, 18.58.06 EEST Hugo Beauzée-Luyssen a écrit 
:
> On Mon, Apr 1, 2019, at 5:27 PM, Rémi Denis-Courmont wrote:
> > Le maanantaina 1. huhtikuuta 2019, 10.07.55 EEST Hugo Beauzée-Luyssen a
> > écrit> 
> > > > This rather questions if the alleged bug is even specific to AArch64 &
> > > > sendmsg.
> > > 
> > > That I agree with, but the sendmsg one I was able to reproduce
> > > systematically.
> > 
> > I don't think we should merge a fix when we do not understand the problem.
> 
> I think that was implied by "The sendmsg patch is ugly and I'm very open to
> alternatives"

I don't know what you did or did not imply. When somebody states that a patch 
is ugly, I tend to assume that they dislike the form rather than the essence.

My chief concerns are that, on the one hand, other system calls may also 
exhibit the bug, and on the other hand, contribs may be affected as well. In 
other words, I am concerned not that the patch is ugly, but that does not 
solve the problem(s).

-- 
Rémi Denis-Courmont
http://www.remlab.net/