[vlc-devel] [RFC PATCH] vout: add the window provider module
thomas at gllm.fr
Thu Apr 4 13:18:32 CEST 2019
On Thu, Apr 4, 2019, at 09:40, Rémi Denis-Courmont wrote:
> This patch is completely broken.
This is a RFC, used to introduce a discussion on the window provider subject. OK I forgot to mention in the commit log, my bad.
> It does not work at all on Wayland.
> It barely works on X11, is not compatible with the existing semantics.
> It includes stuff that makes no sense for an embedded video window.
Which one ?
> It contradicts the design aspects agreed upon at the window and surface workshop.
We just agreed on using callbacks, I don't remember any more details.
> I am not forcing you or anyone to implement this. If you are unwilling or unable to do it, then don't. But don't force me to review such a half-baked "RFC".
I'm not forcing you to review anything, but could you just stop comparing work of other people as a joke ? This is always hurful. Such comment should never take place on VideoLAN mailing-list.
And yes, I'm not mastering the "vout window" very well... I mostly worked on the "vout display" side
> Le 4 avril 2019 10:29:24 GMT+03:00, Thomas Guillem <thomas at gllm.fr> a écrit :
>> On Thu, Apr 4, 2019, at 09:03, Rémi Denis-Courmont wrote:
>>> Untested half-assed patch that does not worl, I will not review it.
>> Hence the RFC. I just wanted to ask if I was going in the good direction.
>> This patch is missing the most important feature, the ability to create more than one "vout window" from the same opaque pointer:
>> - Add a new create_window callback that will return a different opaque pointer (window_opaque).
>> - Call every window ops with this opaque instead of the original one (or both).
>>> Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté.
>>> vlc-devel mailing list
>>> To unsubscribe or modify your subscription options:
> Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté.
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the vlc-devel