[vlc-devel] [PATCH V2 01/17] vout: don't call window operation when disabled

Alexandre Janniaux ajanni at videolabs.io
Tue Apr 16 18:47:18 CEST 2019


On 2019-04-16 18:03, Rémi Denis-Courmont wrote:
> Le tiistaina 16. huhtikuuta 2019, 19.00.25 EEST Thomas Guillem a écrit 
> :
>> On Tue, Apr 16, 2019, at 17:42, Rémi Denis-Courmont wrote:
>> > This is obviously wrong.
>> Please state the obvious.
> Sure shall do - after you please revert your half-baked patches, please 
> stop
> sending half-baked patches for review, and please stop contradicting 
> stuff that
> was already agreed.

I find the message a bit out of the scope of the review.

When it comes to a software as complicated as VLC, it's easier to agree 
on written
documentation. If it is not clear we can try to improve it. Like:

> Window implementation callbacks.

could become

> Window implementation callbacks.
> These callbacks can still be called even when the window is disabled, 
> allowing
> the user to configure the underlying window implementation before 
> enabling it.

Then we would just have to quote the documentation to tell that a patch 
is wrong.

Except from that, I agree with you, setting the state before enabling is 
very convenient for having the window mapped with the correct state 
before mapping
it and avoiding window glitches or lost state changes.


Alexandre Janniaux

More information about the vlc-devel mailing list