[vlc-devel] [PATCH V2 01/17] vout: don't call window operation when disabled

[Jean-Baptiste Kempf]

On Tue, 16 Apr 2019, at 18:04, Rémi Denis-Courmont wrote:
> Le tiistaina 16. huhtikuuta 2019, 19.00.25 EEST Thomas Guillem a écrit :
> > On Tue, Apr 16, 2019, at 17:42, Rémi Denis-Courmont wrote:
> > > This is obviously wrong.
> > 
> > Please state the obvious.
> 
> Sure shall do - after you please revert your half-baked patches, please stop 
> sending half-baked patches for review, and please stop contradicting stuff that 
> was already agreed.

You are blackmailing someone for your reviews in exchange of reverts of his commits?
You MUST be kidding me.


Especially since you are very far from being clean: people spend their time fixing your code.
In the last 2 weeks, I count at least 4 occurrences of that case, including "obvious" build breakage and "obvious" warnings.

Sure, you might have less time than others, but you cannot expect people to be better than you are.
People are human: we make mistakes.

Now, about the player, Thomas (and others) have been working a lot and the merge is quite good, not breaking bisect and working totally fine in command line.
Even the Qt interface works.

Tested today, vlc --no-media-library gets:
- playback audio and video works
- play/pause/stop work fine
- seeking works,
- playlist, including next/previous/random/loop work fine,
- aspect ratio and crop and zoom work fine
- playlist reordering works fine,
- DVD menus and titles and chapter work fine, as are MKV editions (Bluray should too)
- Speed control work
- Jump backward/fwd works
- Audio and subtitles track selection works
- Codec information, Metadata information, Messages dialog are working.
- Preferences are working.
- MPRIS integration works

Sure, the video is splitted (the workaround was refused by you) , some menus are missing (but should be easy to do) and the Chromecast listing in the Qt menu does not work, (and OMG teletext buttons!), but we're very very far from unusable.
And very far from the state of the macOS interface when it was pushed and play/pause did not even work.
So no, revert is not required.

-- 
Jean-Baptiste Kempf -  President
+33 672 704 734