[vlc-devel] [PATCH V2 01/17] vout: don't call window operation when disabled

Jean-Baptiste Kempf jb at videolan.org
Wed Apr 17 04:58:14 CEST 2019


On Tue, 16 Apr 2019, at 17:42, RĂ©mi Denis-Courmont wrote:
> This is obviously wrong.

How the hell is that an acceptable review?

Obvious and trivial means actual trivial, which means stuff like 0 = 0, 1 = 1, deref of NULL or stuff that don't compile on the default compilers.
Anything else cannot be called trivial, and clearly NOT a set of 17 patches, by one of the best developer of VLC.

Totally empty reviews like this one will be ignored, because they are not reviews, but mood swings.

How can one act and fix his contributions with such reviews???
Absolutely unacceptable, unless those reviews must be ignored.

-- 
Jean-Baptiste Kempf -  President


More information about the vlc-devel mailing list