[vlc-devel] [PATCH 00/17] RFC Split block_t into 2 different data containers

[Thomas Guillem]

On Wed, Apr 24, 2019, at 18:35, Denis Charmet wrote:
> Hi,
> 
> On 2019-04-24 15:57, Thomas Guillem wrote:
> > I also 2 other issues with this RFC:
> >  - Drop of flags in vlc_data_t: sadly, there will be no ways for
> > accesses to report a discontinuity. I know it is broken in VLC 3.0
> > since flags are lost in stream filters, but there are a lot of
> > requests to bring back the ability for accesses to notify a
> > discontinuity. We should fix it for 4.0 and therefore keep this flag.
> 
> I thought about it when I was implementing it. And I don't know any 
> pure demux (short of TS) able to handle discontinuity. So you can flag 
> your stream, it will still be ignored. I don't see the point of keeping 
> that before demuxers can handle that.

The ts demuxer can handle it. In the meantime, we hacked it by forging a ts packet that trigger a discontinuity, this is very ugly. 
I don't like creating an access_demux for udp, rist, srt, rtp when we could use the ts demuxer and forward flags from the access. I would prefer to stick to the original plan that was access + demux, and fix the stream-filter to not loose this information once for good.

Maybe we could vote about it and/or hear Francois opinion. 


> 
> Regards,
> -- 
> Denis Charmet - TypX
> Le mauvais esprit est un art de vivre
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel