[vlc-devel] [PATCH 00/17] RFC Split block_t into 2 different data containers

[Rémi Denis-Courmont]

Hi,

The TS demuxer has to detect and handle packet loss internally anyway because raw UDP and DVB accesses _cannot_ detect it. Ditto mid-stream reset. You are getting nowhere with adding a flag that you cannot rely on.

Meanwhile, RTP-TS is already handling stream reset and already uses a semi-ad-hoc interface to the TS demuxer. You don't need to mess with stream filters and vlc_data_t if you want a fully ad-hoc interface there to handle packet loss.

Le 25 avril 2019 05:03:21 GMT+03:00, Thomas Guillem <thomas at gllm.fr> a écrit :
>
>
>On Wed, Apr 24, 2019, at 18:35, Denis Charmet wrote:
>> Hi,
>> 
>> On 2019-04-24 15:57, Thomas Guillem wrote:
>> > I also 2 other issues with this RFC:
>> >  - Drop of flags in vlc_data_t: sadly, there will be no ways for
>> > accesses to report a discontinuity. I know it is broken in VLC 3.0
>> > since flags are lost in stream filters, but there are a lot of
>> > requests to bring back the ability for accesses to notify a
>> > discontinuity. We should fix it for 4.0 and therefore keep this
>flag.
>> 
>> I thought about it when I was implementing it. And I don't know any 
>> pure demux (short of TS) able to handle discontinuity. So you can
>flag 
>> your stream, it will still be ignored. I don't see the point of
>keeping 
>> that before demuxers can handle that.
>
>The ts demuxer can handle it. In the meantime, we hacked it by forging
>a ts packet that trigger a discontinuity, this is very ugly. 
>I don't like creating an access_demux for udp, rist, srt, rtp when we
>could use the ts demuxer and forward flags from the access. I would
>prefer to stick to the original plan that was access + demux, and fix
>the stream-filter to not loose this information once for good.
>
>Maybe we could vote about it and/or hear Francois opinion. 
>
>
>> 
>> Regards,
>> -- 
>> Denis Charmet - TypX
>> Le mauvais esprit est un art de vivre
>> _______________________________________________
>> vlc-devel mailing list
>> To unsubscribe or modify your subscription options:
>> https://mailman.videolan.org/listinfo/vlc-devel
>_______________________________________________
>vlc-devel mailing list
>To unsubscribe or modify your subscription options:
>https://mailman.videolan.org/listinfo/vlc-devel

-- 
Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20190425/f2e1343a/attachment.html>