[vlc-devel] [PATCH] chromecast: transcode audio to MP3 320 kbps instead of 96 kbps

[Jean-Baptiste Kempf]

On Mon, 12 Aug 2019, at 08:57, Thomas Guillem wrote:
> 
> 
> On Sat, Aug 10, 2019, at 09:37, ValdikSS wrote:
> > On 09.08.2019 10:07, Thomas Guillem wrote:
> > > Yes, in the GetAcodecOption() method, you have access to the i_quality enum.
> > > 
> > > You shoud enable 320kbps only for CONVERSION_QUALITY_HIGH, and maybe 160 for MEDIUM.
> > 
> > Francois, Thomas, note this is 320 kbit/s, not kbyte/s.
> 
> We know.
> Then 320 for Medium and High, 96 or 120 for low.

No. 192 is enough for medium.

> 
> > Chromecast is used only on LAN, it doesn't work over the Internet. 
> > Every wireless network is capable of streaming such relatively low 
> > bitrate, and I honestly see no point using lower bitrates since they 
> > have almost no effect on CPU load.
> 
> The quality settings is for CPU load and network bandwidth too. Lot of people have really shitty wifi.
> 
> > Are you sure lower bitrates are needed? I, as a user, expect audio to 
> > be the best quality possible.
> > Also note that currently VLC transcodes MP3 to MP3 again, due to a bug 
> > #22650: https://trac.videolan.org/vlc/ticket/22650
> 
> noted.
> 
> > 
> > > 
> > > On Fri, Aug 9, 2019, at 08:56, Francois Cartegnie wrote:
> > >> Le 08/08/2019 à 21:33, ValdikSS via vlc-devel a écrit :
> > >>> Chromecast transcoding code uses either Vorbis or MP3 for audio.
> > >>> For Vorbis, quality=4 is used, but for MP3 no bitrate or quality
> > >>> setting is set, which leads to default 96 kbps poor quality audio.
> > >>>
> > >>> This patch explicitly sets 320 kbps bitrate for MP3, for much
> > >>> better audio quality.
> > >>
> > >> Way too high for devices & wireless.
> > >>
> > >> -- 
> > >> Francois Cartegnie
> > >> VideoLAN - VLC Developer
> > >> _______________________________________________
> > >> vlc-devel mailing list
> > >> To unsubscribe or modify your subscription options:
> > >> https://mailman.videolan.org/listinfo/vlc-devel
> > > _______________________________________________
> > > vlc-devel mailing list
> > > To unsubscribe or modify your subscription options:
> > > https://mailman.videolan.org/listinfo/vlc-devel
> > > 
> > 
> > 
> > 
> > Attachments:
> > * signature.asc
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel

--
Jean-Baptiste Kempf - President
+33 672 704 734


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20190812/8bb11eac/attachment.html>