[PATCH] chromecast: transcode audio to MP3 320 kbps instead of 96 kbps

[ValdikSS]

On 12.08.2019 10:00, Jean-Baptiste Kempf wrote:
> 
> 
> On Mon, 12 Aug 2019, at 08:57, Thomas Guillem wrote:
>>
>>
>> On Sat, Aug 10, 2019, at 09:37, ValdikSS wrote:
>> > On 09.08.2019 10:07, Thomas Guillem wrote:
>> > > Yes, in the GetAcodecOption() method, you have access to the i_quality enum.
>> > > 
>> > > You shoud enable 320kbps only for CONVERSION_QUALITY_HIGH, and maybe 160 for MEDIUM.
>> > 
>> > Francois, Thomas, note this is 320 kbit/s, not kbyte/s.
>>
>> We know.
>> Then 320 for Medium and High, 96 or 120 for low.
> 
> No. 192 is enough for medium.
> 
I'll try to clarify possible imperfect understanding why I'm against lower bitrates.

VLC Chromecast's transcoding quality setting affects both video and audio quality. It's set to LOW (low quality and low bandwidth) by default, and this setting is available only in advanced menu in GUI (show settings: all).

Chromecast is a non-standalone LAN media player. It's not like a regular TV box. It could be used only as a renderer, but doesn't do anything by itself (no menus, no remote control).
There is regular Chromecast which is audio+video player and a Chromecast Audio, which is audio-only, to convert regular speakers to a Wi-Fi-enabled speakers.
Regular Chromecast is usually connected to a TV, with either TV speakers or a hi-fi stereo. Chromecast Audio is usually connected to hi-fi stereo.

The user downloads VLC to:
1. Listen to audio (music, podcasts)
2. Watch videos (video+audio stream)

For 1 the user (at least I) expects highest quality possible (because most likely it's used with speakers), but they will get low quality audio due to default LOW quality setting.
For 2 audio stream bitrate is much less than a video stream bitrate, making it irrelevant. If the user's Wi-Fi network can handle 4192 kbps stream then it can handle 4320 kbps stream.

320 or 192 kbps bitrate have almost no difference in terms of CPU load.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 868 bytes
Desc: OpenPGP digital signature
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20190812/2247d2ea/attachment.sig>