[vlc-devel] [PATCH V3 2/4] aout: add "audio-bitexact" option

[Rémi Denis-Courmont]

This makes zero sense. If you do bit exact in aout, you don't have a filter chain.

And if you do bit exact in transcode, then you don't have a decoder and an encoder so you even *can't* have a filter chain (this has worked fine for years already).

Le 4 décembre 2019 09:54:06 GMT+01:00, Thomas Guillem <thomas at gllm.fr> a écrit :
>
>On Mon, Dec 2, 2019, at 18:07, Rémi Denis-Courmont wrote:
>> Le keskiviikkona 27. marraskuuta 2019, 10.44.53 EET Thomas Guillem a
>écrit :
>> > On Tue, Nov 26, 2019, at 19:03, Rémi Denis-Courmont wrote:
>> > > Le tiistaina 26. marraskuuta 2019, 17.31.24 EET Thomas Guillem a
>écrit :
>> > > >  src/audio_output/filters.c       | 87
>+++++++++++++++++++-------------
>> > > 
>> > > The checks do not belong there.
>> > 
>> > Which checks ?
>> 
>> The added checks in filters.c
>
>Indeed, it's used outside the aout. Every other users could also
>specify the bit excact mode via aout_filters_cfg_t.
>Ideally, we would move some var bool check to aout_filters_cfg_t too.
>
>> 
>> -- 
>> 雷米‧德尼-库尔蒙
>> http://www.remlab.net/
>> 
>> 
>> 
>> _______________________________________________
>> vlc-devel mailing list
>> To unsubscribe or modify your subscription options:
>> https://mailman.videolan.org/listinfo/vlc-devel
>_______________________________________________
>vlc-devel mailing list
>To unsubscribe or modify your subscription options:
>https://mailman.videolan.org/listinfo/vlc-devel

-- 
Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20191206/70569102/attachment.html>