[vlc-devel] [PATCH V3 2/4] aout: add "audio-bitexact" option

[Thomas Guillem]

On Fri, Dec 6, 2019, at 18:59, Rémi Denis-Courmont wrote:
> This makes zero sense. 

Could you please avoid hurtful sentence in the future ? Same for the "B.S." sent last week on the skins2 mail.
I sent this patch knowing that it needed a discussion. I don't need to be remained how bad my proposal is.
What I would like instead is the opinion of everyone about the 3 possibilities of the "audio-bitexact" mode.

> If you do bit exact in aout, you don't have a filter chain.

I could have used a boolean for the "audio-bitexact" option. In that case, indeed, there is no need to use a filters chain.

But what about --audio-bitexact with an aout specific exclusive mode ?
People won't be able to play mp3 with these 2 modes enabled (FL32 decoder). Is that wanted ? And what about S16N when you have a S24N or S32N soundcard ? 

This is why I added a tertiary option: "convert", that will remove all filters except the one converter that could be needed to adapt to the output format.

Using "on"/"off" for "audio-bitexact" seems dubious. That is why I would prefer using something like the following:

--audio-bitexact=0: default
--audio-bitexact=1: on (with one converter)
--audio-bitexact=2: strict (without any converters)

The big question is: should we remove 1 or 2 ?
If we remove 1, then this option need to be used only by people that master their input and output.
If we remove 2, advanced users won't be able to detect that their whole input/output chain is really bitexact.

> 
> And if you do bit exact in transcode, then you don't have a decoder and an encoder so you even *can't* have a filter chain (this has worked fine for years already).

> 
> Le 4 décembre 2019 09:54:06 GMT+01:00, Thomas Guillem <thomas at gllm.fr> a écrit :
>> 
>> On Mon, Dec 2, 2019, at 18:07, Rémi Denis-Courmont wrote:
>>> Le keskiviikkona 27. marraskuuta 2019, 10.44.53 EET Thomas Guillem a écrit :
>>>> On Tue, Nov 26, 2019, at 19:03, Rémi Denis-Courmont wrote:
>>>>> Le tiistaina 26. marraskuuta 2019, 17.31.24 EET Thomas Guillem a écrit :
>>>>>> src/audio_output/filters.c       | 87 +++++++++++++++++++-------------
>>>>> The checks do not belong there.
>>>> Which checks ?
>>> The added checks in filters.c
>> 
>> Indeed, it's used outside the aout. Every other users could also specify the bit excact mode via aout_filters_cfg_t.
>> Ideally, we would move some var bool check to aout_filters_cfg_t too.
>> 
>> > 
>>> -- 
>>> 雷米‧德尼-库尔蒙
>>> http://www.remlab.net/vlc-devel mailing list
>>> To unsubscribe or modify your subscription options:
>>> https://mailman.videolan.org/listinfo/vlc-devel
>> vlc-devel mailing list
>> To unsubscribe or modify your subscription options:
>> https://mailman.videolan.org/listinfo/vlc-devel
> 
> -- 
> Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté. 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20191209/66bb4dc6/attachment.html>