[vlc-devel] [PATCH V3 2/4] aout: add "audio-bitexact" option

Alexandre Janniaux ajanni at videolabs.io
Mon Dec 9 15:56:02 CET 2019


Hi,

On Mon, Dec 09, 2019 at 03:20:59PM +0100, Thomas Guillem wrote:
> > If you do bit exact in aout, you don't have a filter chain.
>
> I could have used a boolean for the "audio-bitexact" option. In that case, indeed, there is no need to use a filters chain.
>
> But what about --audio-bitexact with an aout specific exclusive mode ?
> People won't be able to play mp3 with these 2 modes enabled (FL32 decoder). Is that wanted ? And what about S16N when you have a S24N or S32N soundcard ?
>
> This is why I added a tertiary option: "convert", that will remove all filters except the one converter that could be needed to adapt to the output format.
>
> Using "on"/"off" for "audio-bitexact" seems dubious. That is why I would prefer using something like the following:
>
> --audio-bitexact=0: default
> --audio-bitexact=1: on (with one converter)
> --audio-bitexact=2: strict (without any converters)
>
> The big question is: should we remove 1 or 2 ?
> If we remove 1, then this option need to be used only by people that master their input and output.
> If we remove 2, advanced users won't be able to detect that their whole input/output chain is really bitexact.

I'd prefer something like

 --audio-bitexact=off
 --audio-bitexact=output-only
 --audio-bitexact=strict

In my opinion, it makes sense to have this, should it be only
for testing purpose and checking everything works correctly
in this mode. And it's already a quite advanced feature so
I don't think it will have any footprint on the UX. To be
honest I don't even think it's an important matter to discuss
how it should be done as long as it is clear for the user. It
is a quite peculiar use case and we won't know how to improve
this before shipping it.

Regards,
--
Alexandre Janniaux
Videolabs


More information about the vlc-devel mailing list