[vlc-devel] [PATCH] splitter: use a different thread for each display

[Rémi Denis-Courmont]

Le keskiviikkona 11. joulukuuta 2019, 15.33.41 EET Alexandre Janniaux a écrit 
:
> > The splitter is not a corner case any longer, I already fixed that for the
> > most part. What's left is necessary for CLI syntax backward compatibility.
> It's far better than before, but it's still a corner case.
> We're checking whether `video-splitter` has a value and
> disable the window creation if so,

Did I mention that was for CLI backward compatibility?

> and the splitter output
> is synchronizing the rendering after the vout_thread whereas
> the vout_thread is actually the synchronization primitive in
> the video pipeline (the one using the clock).

There's no difference there. Prepare and Display are synchronous (even with 
your patch) specifically to exhibit the same flow control semantics as normal.

> Why wouldn't it be? Having a splitter module with different
> filter on each output doesn't seem like a wrong usecase at
> all to me.

This is a no-brainer especially for the panoramix splitter. Blending the SPU 
and applying filters should be on whole pictures, not split sections of whole 
pictures.

-- 
Rémi Denis-Courmont
http://www.remlab.net/