[vlc-devel] [PATCH] splitter: use a different thread for each display

[Alexandre Janniaux]

Hi,

On Wed, Dec 11, 2019 at 06:59:14PM +0200, Rémi Denis-Courmont wrote:
> Le keskiviikkona 11. joulukuuta 2019, 15.33.41 EET Alexandre Janniaux a écrit
> :
> > > The splitter is not a corner case any longer, I already fixed that for the
> > > most part. What's left is necessary for CLI syntax backward compatibility.
> > It's far better than before, but it's still a corner case.
> > We're checking whether `video-splitter` has a value and
> > disable the window creation if so,
>
> Did I mention that was for CLI backward compatibility?

Sorry, I don't understand, I'm not critizing what you did and
this is off topic.

> > and the splitter output
> > is synchronizing the rendering after the vout_thread whereas
> > the vout_thread is actually the synchronization primitive in
> > the video pipeline (the one using the clock).
>
> There's no difference there. Prepare and Display are synchronous (even with
> your patch) specifically to exhibit the same flow control semantics as normal.

That's for change unrelated to this patchset anyway, like
written in previous mail.

> > Why wouldn't it be? Having a splitter module with different
> > filter on each output doesn't seem like a wrong usecase at
> > all to me.
>
> This is a no-brainer especially for the panoramix splitter. Blending the SPU
> and applying filters should be on whole pictures, not split sections of whole
> pictures.

I'll move this topic to a new discussion later to focus on
the review. It's currently unrelated.

Regards,
--
Alexandre Janniaux
Videolabs