[vlc-devel] [vlc-commits] decoder: move decoder_UpdateVideoFormat() into a function

[Rémi Denis-Courmont]

Video filters have nothing to do with this, since decoder_t and filter_t are (currently) different and filters don't have a format update callback (so far).

As far as I understand push-buffers, the decoder video format is intended to track the output format, not the allocation format. So then there are absolutely no ways that it can be involved with the picture pool, the format of which it does not even know.

Le 19 février 2019 01:19:53 GMT+02:00, Steve Lhomme <robux4 at ycbcr.xyz> a écrit :
>
>
>> On 18 Feb 2019, at 19:43, Rémi Denis-Courmont <remi at remlab.net>
>wrote:
>> 
>> Le maanantaina 18. helmikuuta 2019, 19.43.04 EET Steve Lhomme a écrit
>:
>>> That's where the pool and video context will be handled
>> 
>> I don't see how that would work. The video context is supposed to
>move
>
>It cannot move if it doesn't exist yet.
>
>It will be created by hardware decoders but can as well be initiated by
>any video filter. There's also the case of legacy/CPU decoders who will
>still need their own pool and a dummy context (in my implementation
>NULL video context is not allowed in most places).
>
>This is where it all happens.
>
>And what was done in the vout on the format before creating the pool
>will also need to go in there.
>
>This is a lot.
>
>> to the 
>> hardware decoder. To the core, it is just an opaque pointer to pass
>around.
>> 
>> And then the pool stems from the video context so...
>> 
>> -- 
>> 雷米‧德尼-库尔蒙
>> http://www.remlab.net/
>> 
>> 
>> 
>> _______________________________________________
>> vlc-devel mailing list
>> To unsubscribe or modify your subscription options:
>> https://mailman.videolan.org/listinfo/vlc-devel
>
>_______________________________________________
>vlc-devel mailing list
>To unsubscribe or modify your subscription options:
>https://mailman.videolan.org/listinfo/vlc-devel

-- 
Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20190219/5f90eeb9/attachment.html>