[vlc-devel] [vlc-commits] decoder: make decoder_Clean() public

Rémi Denis-Courmont remi at remlab.net
Wed Feb 20 11:23:54 CET 2019


I don't think that there is a question whether there should always be a pool, because it now depends on the decoder plugin. We don't know what the decoder does or does not do internally, so there are no ways to generically allocate a pool outside on a systematic basis.

And it would be insane to allocate a whole pool for image decoders, especially considering that pictures tend to be larger than video frames. Image decoders should allocate their picture explicitly.

No, the first question is what would the determinant be to allocate a pool for the decoder or let the decoder manage its pool.

Le 20 février 2019 12:01:52 GMT+02:00, Steve Lhomme <robux4 at ycbcr.xyz> a écrit :
>On 20/02/2019 09:56, Thomas Guillem wrote:
>> Please,  send future decoder patches on the ML first.
>BTW do we agree on my 13+1 patchset, generalizing the work on the
>format passed to update_format() ?
>Later this format will be the one used for the decoder pool. And 
>possibly set on dec->fmt_out.video, although in my branch I kept a 
>separate one to check the pool format against it.
>vlc-devel mailing list
>To unsubscribe or modify your subscription options:

Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20190220/e0bc65f8/attachment-0001.html>

More information about the vlc-devel mailing list