[vlc-devel] [PATCH] contrib: force uid/gid during tarball extractions

Simon Latapie garf at videolan.org
Wed Jan 9 15:46:40 CET 2019


Under rare circonstances, tar will try to preserve uid/gid no matter what,
and fail.
This can happen for example when trying to build the contribs as a
privileged user inside a namespaced container.
---
 contrib/src/main.mak | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/contrib/src/main.mak b/contrib/src/main.mak
index d96f70f96d..34ad2fd5ff 100644
--- a/contrib/src/main.mak
+++ b/contrib/src/main.mak
@@ -332,9 +332,9 @@ checksum = \
 		"$(SRC)/$(patsubst .sum-%,%,$@)/$(2)SUMS"
 CHECK_SHA512 = $(call checksum,$(SHA512SUM),SHA512)
 UNPACK = $(RM) -R $@ \
-	$(foreach f,$(filter %.tar.gz %.tgz,$^), && tar xvzf $(f)) \
-	$(foreach f,$(filter %.tar.bz2,$^), && tar xvjf $(f)) \
-	$(foreach f,$(filter %.tar.xz,$^), && tar xvJf $(f)) \
+	$(foreach f,$(filter %.tar.gz %.tgz,$^), && tar xvzf $(f) --no-same-owner) \
+	$(foreach f,$(filter %.tar.bz2,$^), && tar xvjf $(f) --no-same-owner) \
+	$(foreach f,$(filter %.tar.xz,$^), && tar xvJf $(f) --no-same-owner) \
 	$(foreach f,$(filter %.zip,$^), && unzip $(f))
 UNPACK_DIR = $(patsubst %.tar,%,$(basename $(notdir $<)))
 APPLY = (cd $(UNPACK_DIR) && patch -fp1) <
-- 
2.11.0



More information about the vlc-devel mailing list