[vlc-devel] [PATCH] contrib: dav1d: disable asm for Android x86

Jean-Baptiste Kempf jb at videolan.org
Wed Jan 9 18:39:28 CET 2019


This is not the right fix: the right fix is to update dav1d after the fix for this issue.

On Wed, 9 Jan 2019, at 00:09, Thomas Guillem wrote:
> This fixes the following warning (treated as error) on Android:
> 
> "ld: warning: shared library text segment is not shareable"
> ---
>  contrib/src/dav1d/rules.mak | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/contrib/src/dav1d/rules.mak b/contrib/src/dav1d/rules.mak
> index a4cb58b079..8bbd40c0e7 100644
> --- a/contrib/src/dav1d/rules.mak
> +++ b/contrib/src/dav1d/rules.mak
> @@ -16,6 +16,12 @@ ifdef HAVE_WIN32
>  DAV1D_CONF += -D win32_ver=false
>  endif
>  
> +ifdef HAVE_ANDROID
> +ifeq ($(ARCH),i386)
> +DAV1D_CONF += -D build_asm=false
> +endif
> +endif
> +
>  $(TARBALLS)/dav1d-$(DAV1D_VERSION).tar.xz:
>  	$(call download_pkg,$(DAV1D_URL),dav1d)
>  	#~ $(call download_git,$(DAV1D_URL),,$(DAV1D_HASH))
> -- 
> 2.20.1
> 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel


-- 
Jean-Baptiste Kempf -  President
+33 672 704 734


More information about the vlc-devel mailing list