[vlc-devel] [PATCH 2/2] linux: Add for kms vout plugin possibility to choose output display

[Juha-Pekka Heikkilä]

Rémi Denis-Courmont kirjoitti 14.1.2019 klo 19.34:
 > Le maanantaina 14. tammikuuta 2019, 15.44.31 EET Juha-Pekka Heikkila 
a écrit :
 >> On 13.1.2019 12.09, Rémi Denis-Courmont wrote:
 >>> Le torstaina 10. tammikuuta 2019, 14.21.54 EET Juha-Pekka Heikkila 
a écrit
 > :
 >>>> Up to this point kms vout plugin chose first enumerated display to
 >>>> be used for output. Now added parameter --kms-connector which will
 >>>> accept number. List of available connectors are printed out by
 >>>> kms vout plugin in debug prints when run in verbose mode.
 >>>
 >>> Isn't this better done with the nascent generic fullscreen output
 >>> selection
 >>> (vout_window_SetFullscreen) interface than a custom parameter?
 >>
 >> That sound like it would be coming from windowed system to full screen?
 >> That would not work with kms as when kms is initialized there cannot be
 >> other software owning display.
 >
 > I fail to see the causal link here.

I'm maybe missing some part here. To me 'window_SetFullscreen' sound 
like it will happen in windowed environment. When kms plugin try to 
launch from vlc it will have requirement nobody has set up graphics 
environment at that point. If someone else has set up graphics 
environment that someone else will own 'drmmaster' and kms plugin will 
not gain 'drmmaster' and thus not be able to gain control.

For example when Xorg is running on screen Xorg has drmmaster and nobody 
else can steal it. Once go from Xorg to text terminal Xorg will release 
drmmaster and this is where one can run vlc with kms while Xorg is on 
background.

 >> This patch was earlier on list when you suggested to try use
 >> change_integer_cb() for this selection. Alas this didn't work unless
 >> running in (qt) gui
 >
 > Uh? wut? change_integer_cb() works with the CLI help, and you're 
welcome to
 > add it wherever else you see fit.

I tried change_integer_cb() but my callback to populate the list was 
never called. This is how I tried it 
https://mailman.videolan.org/pipermail/vlc-devel/2018-September/121198.html

And this is where discussion about this feature ended last time 
https://mailman.videolan.org/pipermail/vlc-devel/2018-September/121251.html

/Juha-Pekka