[vlc-devel] [PATCH 1/3] vdpau/display: remove unused has_pictures_invalid

[Steve Lhomme]

OK so the documentation of "has_pictures_invalid" needs to be changed. 
vout_display_SendEventPicturesInvalid() indirectly calls 
VOUT_DISPLAY_RESET_PICTURES which is also what happens when a 
resize/crop/etc error occurs but synchronously.

So has_pictures_invalid means the display handles 
VOUT_DISPLAY_RESET_PICTURES.

On 16/01/2019 12:55, Rémi Denis-Courmont wrote:
> It is done synchronously by return value, rather than with a brittle 
> asynchronous callback. But if course it's still done. X11 vout will 
> never be able to scale on its own.
>
> I guess I should have aliased the error code afterall.
>
> Le 16 janvier 2019 09:46:43 GMT+02:00, Steve Lhomme <robux4 at ycbcr.xyz> 
> a écrit :
>
>     On 16/01/2019 08:32, Rémi Denis-Courmont wrote:
>
>         And? VDPAU and X11 still need to reset their input format as
>         they cannot scale. 
>
>
>     But it doesn't appear to be done anymore. Did I miss something ?
>
>     >
>
>         Of course, it is questionable whether the flag is at all
>         useful anymore, but that's a separate issue. Le 16 janvier
>         2019 09:29:02 GMT+02:00, Steve Lhomme <robux4 at ycbcr.xyz> a
>         écrit : The module doesn't call
>         vout_display_SendEventPicturesInvalid() anymore.
>         ------------------------------------------------------------------------
>         modules/hw/vdpau/display.c | 1 - 1 file changed, 1 deletion(-)
>         diff --git a/modules/hw/vdpau/display.c
>         b/modules/hw/vdpau/display.c index 3bf0475fcf..c5ebf6639f
>         100644 --- a/modules/hw/vdpau/display.c +++
>         b/modules/hw/vdpau/display.c @@ -498,7 +498,6 @@ static int
>         Open(vout_display_t *vd, const vout_display_cfg_t *cfg, /* */
>         sys->current = NULL; vd->sys = sys; -
>         vd->info.has_pictures_invalid = true;
>         vd->info.subpicture_chromas = spu_chromas; *fmtp = fmt; --
>         Envoyé de mon appareil Android avec Courriel K-9 Mail.
>         Veuillez excuser ma brièveté.
>         ------------------------------------------------------------------------
>         vlc-devel mailing list To unsubscribe or modify your
>         subscription options:
>         https://mailman.videolan.org/listinfo/vlc-devel 
>
>     ------------------------------------------------------------------------
>     vlc-devel mailing list
>     To unsubscribe or modify your subscription options:
>     https://mailman.videolan.org/listinfo/vlc-devel
>
>
> -- 
> Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez 
> excuser ma brièveté.
>
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel