[vlc-devel] [PATCH 1/3] vdpau/display: remove unused has_pictures_invalid

Rémi Denis-Courmont remi at remlab.net
Wed Jan 16 16:59:05 CET 2019


Le keskiviikkona 16. tammikuuta 2019, 14.33.52 EET Steve Lhomme a écrit :
> OK so the documentation of "has_pictures_invalid" needs to be changed.
> vout_display_SendEventPicturesInvalid() indirectly calls
> VOUT_DISPLAY_RESET_PICTURES which is also what happens when a
> resize/crop/etc error occurs but synchronously.
> 
> So has_pictures_invalid means the display handles
> VOUT_DISPLAY_RESET_PICTURES.

It rather means that the display may need VOUT_DISPLAY_RESET_PICTURES. Though 
in practice, it only really affects pool allocation, and should be irrelevant 
if the display uses push-buffers.

So it should be possible to remove it from VDPAU and X11 eventually after some 
further clean-ups.

-- 
雷米‧德尼-库尔蒙
http://www.remlab.net/





More information about the vlc-devel mailing list