[vlc-devel] libvlc, modify replay gain setting and third party application

[Matthieu Gallien]

Hello,

On vendredi 11 janvier 2019 08:55:43 CET Rémi Denis-Courmont wrote:
> Hi,
> 
> There is no API for that, and adding one is not obviously such a good idea.
> There are a number of issues. For a start, VLC has always disabled the
> option by default, so there is no understanding of how well this works.
> Then having more choices than on & off makes little sense to most. And
> lastly, it won't work when pass-through is negotiated.

Thanks for your answer (and others in the thread). I missed most answers due 
to me forgetting to ask CC and not being subscribed (I have fixed that).

From the different replies to my mail, I have currently decided to see if I 
could test this feature by using command line arguments passed to libvlc_new 
function.

I would like to optionally propose to the user to specify :
* no replay gain ever ;
* replay gain and in case both modes are possible to prefer album gain ;
* replay gain and in case both modes are possible to prefer single track gain.

I would always automatically fallback to any of the gain if only one exists in 
the metadata.

If and only if there is a consensus about the possibility to use another way 
to set this when calling libvlc, I will be happy to work on it. In the 
meantime, I will work through libvlc_new parameters.

> Le 10 janvier 2019 23:32:30 GMT+02:00, mgallien <gallien.matthieu at gmail.com> 
a écrit :
> >Hello,
> >
> >I am Matthieu Gallien and I am working on the Elisa music player as
> >part of
> >the KDE project.
> >
> >I am now using libvlc (when found with a fallback to QtMultimedia
> >module) to
> >play music. This has been really a pleasant work to integrate libvlc.
> >
> >I am adding support for replay gain through libvlc. I would like to be
> >able to
> >modify the "audio-replay-gain-mode" setting to allow users to choose
> >between
> >the different replay gain modes.
> >
> >I tried looking at the different API available in libvlc and failed to
> >found
> >one to do that (except calling libvlc_new with different arguments).
> >
> >Is there already something that allows that ?
> >
> >I have looked at the code in
> >modules/gui/qt/components/simple_preferences.cpp
> >that declare the replay gain settings and the code in modules/gui/qt/
> >components/preferences_widgets.cpp to apply the modified settings.
> >
> >If it is not currently possible to modify this setting through libvlc,
> >what is
> >the best approach to do it ?
> >
> >Should I write a specific module that would allow my code to modify the
> >setting
> >or add support for that in libvlc API ?
> >
> >Thanks in advance for your help
> >
> >Best regards
> >
> >--
> >Matthieu Gallien
> >
> >
> >_______________________________________________
> >vlc-devel mailing list
> >To unsubscribe or modify your subscription options:
> >https://mailman.videolan.org/listinfo/vlc-devel

Best regards