[vlc-devel] [PATCH 1/3] vdpau/display: remove unused has_pictures_invalid

[Rémi Denis-Courmont]

Le torstaina 17. tammikuuta 2019, 16.34.08 EET Steve Lhomme a écrit :
> On 16/01/2019 16:59, Rémi Denis-Courmont wrote:
> > Le keskiviikkona 16. tammikuuta 2019, 14.33.52 EET Steve Lhomme a écrit :
> >> OK so the documentation of "has_pictures_invalid" needs to be changed.
> >> vout_display_SendEventPicturesInvalid() indirectly calls
> >> VOUT_DISPLAY_RESET_PICTURES which is also what happens when a
> >> resize/crop/etc error occurs but synchronously.
> >> 
> >> So has_pictures_invalid means the display handles
> >> VOUT_DISPLAY_RESET_PICTURES.
> > 
> > It rather means that the display may need VOUT_DISPLAY_RESET_PICTURES.
> > Though in practice, it only really affects pool allocation, and should be
> > irrelevant if the display uses push-buffers.
> 
> "if the display uses push buffers" yes. But there are some cases where
> it's not possible. In many display modules the display pool has its own
> lock/unlock callbacks.

I stopped reading here. Lock/unlock has been flaky, not to say plainly broken, 
for as long as I remember - which is at least as long as picture_pool_t 
existed. I don't recall if/how the callbacks worked before.

-- 
雷米‧德尼-库尔蒙
http://www.remlab.net/