[vlc-devel] [PATCH 1/3] vdpau/display: remove unused has_pictures_invalid

Steve Lhomme robux4 at ycbcr.xyz
Thu Jan 17 15:34:08 CET 2019

On 16/01/2019 16:59, Rémi Denis-Courmont wrote:
> Le keskiviikkona 16. tammikuuta 2019, 14.33.52 EET Steve Lhomme a écrit :
>> OK so the documentation of "has_pictures_invalid" needs to be changed.
>> vout_display_SendEventPicturesInvalid() indirectly calls
>> VOUT_DISPLAY_RESET_PICTURES which is also what happens when a
>> resize/crop/etc error occurs but synchronously.
>> So has_pictures_invalid means the display handles
> It rather means that the display may need VOUT_DISPLAY_RESET_PICTURES. Though
> in practice, it only really affects pool allocation, and should be irrelevant
> if the display uses push-buffers.

"if the display uses push buffers" yes. But there are some cases where 
it's not possible. In many display modules the display pool has its own 
lock/unlock callbacks. This is used for "indirect" rendering. The lock 
happens before copying the decoder picture to the display picture. And 
it happens inside the pool, it's not an API of the picture.

So for now these display modules will need to keep their pool and we'll 
need to write in there.

The modules that both handle a VOUT_DISPLAY_RESET_PICTURES and such a 
lock are mmal, direct3d9, directdraw.
> So it should be possible to remove it from VDPAU and X11 eventually after some
> further clean-ups.
> -- 
> 雷米‧德尼-库尔蒙
> http://www.remlab.net/
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel

More information about the vlc-devel mailing list