[vlc-devel] [PATCH 2/3] taglib: Allow non-local mrls to be analyzed when preparsing

[Rémi Denis-Courmont]

Le keskiviikkona 30. tammikuuta 2019, 18.22.42 EET Hugo Beauzée-Luyssen a 
écrit :
> On Wed, Jan 23, 2019, at 5:09 PM, Rémi Denis-Courmont wrote:
> > Le keskiviikkona 23. tammikuuta 2019, 16.09.22 EET Hugo Beauzée-Luyssen a
> > 
> > écrit :
> > > We don't do this during playback as it can slow down the playback quite
> > > noticeably
> > 
> > I don't think that works.
> > 
> > On the one hand, if the resource is slow (or worse, locks up), the
> > preparsing queue still jams and preparsing essentially fails for any
> > further item.
> > 
> > On the other hand, even files from the VFS can be slow, or even
> > infinitely slow,
> > typically (but not only) network file systems.
> 
> I'm not sure I understand your comment; with regard to preparsing,

The point is that there is a certain problem in certain circumstances, and the 
patchset provides a solution that does not match the problem, and in cases 
that do not match the circumstances of the problem.

If you don't want to parse when seeking is slow, you can check FASTSEEK 
already. And I don't think that there should be any difference in preparsing 
and playing in this respect.

> isn't
> that what timeout is about?

In my experience, this "timeout" is either not working at all or it is way too 
generous.

-- 
Rémi Denis-Courmont
http://www.remlab.net/