[vlc-devel] [PATCH] vout:opengl: do the texture initial resize when the output chroma is known

Steve Lhomme robux4 at ycbcr.xyz
Thu Jan 31 08:56:12 CET 2019

On 30/01/2019 22:04, Rémi Denis-Courmont wrote:
> Le tiistaina 29. tammikuuta 2019, 11.26.37 EET Steve Lhomme a écrit :
>> It's even bypassing the call to ResizeFormatToGLMaxTexSize().
> I don't think that's right. That would start OpenGL on a surface with a
> undefined size, whatever that means (i.e. depends on the backend).
> In fact, it's really an old neglected (by me) wart that we don't pass the
> initial size to vlc_gl_Create() up-front.

OK, it doesn't make sense to start using a size if you don't even know 
what format you're supposed to allocate. Also, as said in the comment 
ResizeFormatToGLMaxTexSize() is bypassed and that should never happen.

More information about the vlc-devel mailing list