[vlc-devel] [PATCH] vout:opengl: do the texture initial resize when the output chroma is known

[Rémi Denis-Courmont]

Le torstaina 31. tammikuuta 2019, 17.29.46 EET Steve Lhomme a écrit :
> On 31/01/2019 10:13, Rémi Denis-Courmont wrote:
> > Hi,
> > 
> > I don't see why the format has any influence here. The core will
> > already have determined the size accounting for any dependency on the
> > input format, and the windowing system policies, such that the display
> > configuration provides the correct size already when the display is
> > being created. This is as true for GL as any other display plugin.
> > 
> > We need the size to create the vlc_gl_surface. Currently we just pass
> > a bogus value (egl.c:276), and rely on the fact that the resize
> > callback will be called *immediately* thereafter *before* GL makes use
> > of the context and surface. Somehow I just forgot to clean that up,
> > when I wrote that code.
> 
> The problem is the chroma. For now We assume it's always RGBA 8 bits but
> in the future we should support 10 bits rendering and maybe YUV as well.
> Allocating the rendering buffers is not correct if you don't have these
> information.

I fail to see the link. Maybe we will need to negotiate the bit depths in the 
future, through the GL provider API in some as yet undecided manner. But that 
changes nothing to the fact that we MUST give the surface size to the GL 
provider before we use it, then keep it up-to-date.

-- 
Rémi Denis-Courmont
http://www.remlab.net/