[vlc-devel] [PATCH] vout:opengl: do the texture initial resize when the output chroma is known

[Steve Lhomme]

On 31/01/2019 10:13, Rémi Denis-Courmont wrote:
> Hi,
>
> I don't see why the format has any influence here. The core will 
> already have determined the size accounting for any dependency on the 
> input format, and the windowing system policies, such that the display 
> configuration provides the correct size already when the display is 
> being created. This is as true for GL as any other display plugin.
>
> We need the size to create the vlc_gl_surface. Currently we just pass 
> a bogus value (egl.c:276), and rely on the fact that the resize 
> callback will be called *immediately* thereafter *before* GL makes use 
> of the context and surface. Somehow I just forgot to clean that up, 
> when I wrote that code.

The problem is the chroma. For now We assume it's always RGBA 8 bits but 
in the future we should support 10 bits rendering and maybe YUV as well. 
Allocating the rendering buffers is not correct if you don't have these 
information.

>
> Le 31 janvier 2019 09:56:12 GMT+02:00, Steve Lhomme <robux4 at ycbcr.xyz> 
> a écrit :
>
>     On 30/01/2019 22:04, Rémi Denis-Courmont wrote:
>
>         Le tiistaina 29. tammikuuta 2019, 11.26.37 EET Steve Lhomme a
>         écrit :
>
>             It's even bypassing the call to ResizeFormatToGLMaxTexSize(). 
>
>         I don't think that's right. That would start OpenGL on a
>         surface with a undefined size, whatever that means (i.e.
>         depends on the backend). In fact, it's really an old neglected
>         (by me) wart that we don't pass the initial size to
>         vlc_gl_Create() up-front. 
>
>
>     OK, it doesn't make sense to start using a size if you don't even know
>     what format you're supposed to allocate. Also, as said in the comment
>     ResizeFormatToGLMaxTexSize() is bypassed and that should never happen.
>     ------------------------------------------------------------------------
>     vlc-devel mailing list
>     To unsubscribe or modify your subscription options:
>     https://mailman.videolan.org/listinfo/vlc-devel
>
>
> -- 
> Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez 
> excuser ma brièveté.
>
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel