[vlc-devel] [PATCH] qml: Aspect ratio widget changes

Rohan Rajpal rohanvideolan at gmail.com
Mon Jul 29 09:35:42 CEST 2019


On Mon, Jul 29, 2019, 1:02 PM Alexandre Janniaux <ajanni at videolabs.io>
wrote:

> Hi,
>
>
> On Mon, Jul 29, 2019 at 10:22:25AM +0530, Rohan Rajpal wrote:
> > On Mon, Jul 29, 2019 at 2:38 AM Alexandre Janniaux <ajanni at videolabs.io>
> > wrote:
> >
> > > Hi,
> > >
> > > It seems strange to assign an aspect ratio component to a width.
> > > Is it about setting the size of the aspect ratio button ?
> > >
> > Yeah.
> > I've got a better idea. Add generic values(width_xsmall, width_large etc)
> > in VLCStyle and use those here. I need to use these values in the editor
> > patches anyway.
>
> This looks far better indeed, but would these values being used for the
> whole
> interface or just the buttons ?
>
Whole interface.

>
> Regards,
> --
> Alexandre Janniaux
> VideoLabs
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20190729/dd4bcc7b/attachment.html>


More information about the vlc-devel mailing list