[vlc-devel] [PATCH] qml: Aspect ratio widget changes

[Pierre Lamot]

On 2019-07-29 09:35, Rohan Rajpal wrote:
> On Mon, Jul 29, 2019, 1:02 PM Alexandre Janniaux <ajanni at videolabs.io>
> wrote:
> 
>> Hi,
>> 
>> On Mon, Jul 29, 2019 at 10:22:25AM +0530, Rohan Rajpal wrote:
>>> On Mon, Jul 29, 2019 at 2:38 AM Alexandre Janniaux
>> <ajanni at videolabs.io>
>>> wrote:
>>> 
>>>> Hi,
>>>> 
>>>> It seems strange to assign an aspect ratio component to a width.
>>>> Is it about setting the size of the aspect ratio button ?
>>>> 
>>> Yeah.
>>> I've got a better idea. Add generic values(width_xsmall,
>> width_large etc)
>>> in VLCStyle and use those here. I need to use these values in the
>> editor
>>> patches anyway.
>> 
>> This looks far better indeed, but would these values being used for
>> the whole
>> interface or just the buttons ?
> 
> Whole interface.
> 

width_xsmall, width_large are too vague in my opinion, it provides no 
information on where it can be used. Everything has a width.
I'd prefer something like combobox_width_small in you case.

>> Regards,
>> --
>> Alexandre Janniaux
>> VideoLabs
>> _______________________________________________
>> vlc-devel mailing list
>> To unsubscribe or modify your subscription options:
>> https://mailman.videolan.org/listinfo/vlc-devel
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel