[vlc-devel] [PATCH] decoder: remove input thread and ES dependency
rom1v at videolabs.io
Thu Jun 20 16:43:48 CEST 2019
On Thu, Jun 20, 2019 at 05:10:23PM +0300, Rémi Denis-Courmont wrote:
> Le torstaina 20. kesäkuuta 2019, 14.55.59 EEST Romain Vimont a écrit :
> > +#define decoder_Notify(decoder_priv, event, ...) \
> > + if (decoder_priv->cbs && decoder_priv->cbs->event) \
> > + decoder_priv->cbs->event(&decoder_priv->dec, ##__VA_ARGS__, \
> > + decoder_priv->cbs_userdata);
> I don't think that syntax is valid CPP.
##__VA_ARGS__ is widely supported, and is already used in the core (some
of them from me) and some modules. IMO it's better than defining another
macro specific to 0 varargs.
Anyway, decoder_Notify() is never called with 0 varargs, so I can just
remove "##" here.
More information about the vlc-devel