[vlc-devel] [PATCH] decoder: remove input thread and ES dependency

[Rémi Denis-Courmont]

Le torstaina 20. kesäkuuta 2019, 17.43.48 EEST Romain Vimont a écrit :
> On Thu, Jun 20, 2019 at 05:10:23PM +0300, Rémi Denis-Courmont wrote:
> > Le torstaina 20. kesäkuuta 2019, 14.55.59 EEST Romain Vimont a écrit :
> > > +#define decoder_Notify(decoder_priv, event, ...) \
> > > +    if (decoder_priv->cbs && decoder_priv->cbs->event) \
> > > +        decoder_priv->cbs->event(&decoder_priv->dec, ##__VA_ARGS__, \
> > > +                                 decoder_priv->cbs_userdata);
> > 
> > I don't think that syntax is valid CPP.
> 
> ##__VA_ARGS__ is widely supported, and is already used in the core (some
> of them from me) and some modules. IMO it's better than defining another
> macro specific to 0 varargs.

Changing language is way outside the scope of this patch. And I don't think 
it's a good idea even. Plenty of static analyzers and proprietary compilers do 
not support GNU extensions.

-- 
Rémi Denis-Courmont
http://www.remlab.net/